chore: Improve error handling for invalid regex delimiter #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace panic with graceful error handling when an invalid regex delimiter is provided. Instead of crashing the application, now: - Shows a clear warning message to the user - Falls back to the default delimiter pattern `[\t\n ]+` - Allows the application to continue running normally This prevents crashes from invalid user input while maintaining functionality and providing helpful feedback. Fixes potential crashes when users provide malformed regex patterns as delimiters through command-line options. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dogabudak
changed the title
|
Hi, thank you for this contribution. Could you please add screenshots of the behaviour before and after your change ? Sorry for the delayed answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace panic with graceful error handling when an invalid regex delimiter is provided. Instead of crashing the application, now:
[\t\n ]+This prevents crashes from invalid user input while maintaining functionality and providing helpful feedback.
Fixes potential crashes when users provide malformed regex patterns as delimiters through command-line options.